-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes dev/core#4060: Fix cv
failure on J3.
#25287
Conversation
(Standard links)
|
Can you put against 5.58? It sounds like this broke in 5.56. |
@aydun Can you rebase? It would be good to get this into a point release. |
@demeritcowboy - see #25306 |
+1 for 5.58-rc variant. Patch looks plausible from a distance. Any concerns @seamuslee001 @monishdeb? |
This seems fine to me just needs to be on the 5.58 branch |
looks good to me too and yes it should be on 5.58-rc branch |
@seamuslee001 @totten I have submitted 5.58-rc PR #25320 on behalf of @aydun |
I think this should be included in a 5.57.x release (and maybe 5.56.x). A lot of people will be upgrading because of the security patches and find their cron breaks. |
Thanks @monishdeb So we have:
Should cover most bases! |
5.57 now merged. This was magically upmerged into master already via 5b8696f |
Overview
cv
fails on J3 - see dev/core#4060Before
Failed to start application
errorAfter
No error
Technical Details
This code was changed by #24796 for J4 compatibility.
This PR simply reverts to the previous command for J3 leaving J4 as is.