Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/core#3844) Dummy payment processor should be flagged as such on … #25282

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

yashodha
Copy link
Contributor

@yashodha yashodha commented Jan 5, 2023

…LIVE page

Overview

When dummy payment processor is configured for contribution pages/ event, there is no indication that is NOT a real transaction. This could be confusing and we should flag any LIVE page that is configured with dummy processor.

Before

No indication

After

ec

@civibot
Copy link

civibot bot commented Jan 5, 2023

(Standard links)

@civibot civibot bot added the master label Jan 5, 2023
@demeritcowboy
Copy link
Contributor

demeritcowboy commented Jan 6, 2023

Unrelated test fail.

I like this and it works well, just might suggest fixing the missing "a" in the grammar: "This page is currently configured with a test payment processor". Or maybe instead of $dummy being a number it could be the title of the payment processor, and then output that, like {ts 1=$dummyTitle|escape}This page is currently configured to use the %1 payment processor. ...{/ts}

@yashodha
Copy link
Contributor Author

yashodha commented Jan 9, 2023

@demeritcowboy Thanks for your suggestions. I have incorporated the same and updated the PR. Can you please check?
Screenshot from 2023-01-09 19-39-58

@demeritcowboy
Copy link
Contributor

Looks good!

@demeritcowboy demeritcowboy merged commit ea39ef4 into civicrm:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants