Remove unreachable code (since 2020)

[eileenmcnaughton]

Overview

Remove unreachable code (since 2020)

Before

This function MUST return an array due to the type hint

The last few lines of the code (after the last return has failed) do not return anything - so they will always cause a fatal error & never work. The earlier code suggests it should be unreachable & 2 years of no reports of this error confirms

After

For clarity the unreachable function call is replaced with an exception

Technical Details

CRM_Contribute_BAO_ContributionPage::sendMail is toxic so less calls to it = better

Comments

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[yashodha]

@eileenmcnaughton merging this

[eileenmcnaughton]

thanks @yashodha - did you mean to merge already?

[yashodha]

@eileenmcnaughton oops, I thought I did!

[eileenmcnaughton]

:-)