Move part of deprecated function loadRelatedObjects to calling functions
#25267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
mattwire
reviewed
Jan 2, 2023
| @@ -1833,7 +1833,22 @@ public static function transitionComponents($params) { | |||
| } | |||
| } | |||
|
|
|||
| $contribution->loadRelatedObjects($input, $ids); | |||
| $paymentProcessorID = CRM_Utils_Array::value('payment_processor_id', $input, CRM_Utils_Array::value( | |||
There was a problem hiding this comment.
We should be using ?? instead of CRM_Utils_Value but I can see this is a straight extraction so ok.
There was a problem hiding this comment.
@mattwire yeah - I avoided any cleanup in it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Move part of deprecated function
loadRelatedObjectsto calling functionsBefore
It turns out
$inputis only used for the extraction of one value ($paymentProcessorID) - so we should pass only that value inAfter
Only that value is passed in
Technical Details
I copied back the code to the calling functions - one of them could be further tidied up but I left that out of scope for this PR to keep it easy to review
Comments
This code was the very first function we started refactoring off the form layer with test support - still going... a decade later