Smarty notice fix on contact search results

[eileenmcnaughton]

Overview

Smarty notice fix on contact search results - with smarty default escaping on you can see this just doing a basic Contact Search with no criteria

Before

e-notices when searching with escape-on-output

After

empty check removed in favour of making it present - contact who can't see deleted contacts won't get them returned so we should put it in the array regardless of contact permissions

Technical Details

Comments

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

I think this is ok just noting the actual is_deleted functionality doesn't work before or after the patch, i.e. is_deleted never seems to be true regardless of whether the contact is deleted or not. At least for basic search and advanced search. I don't even think you can get deleted contacts from basic search.

Further, this styling seems pointless if you can only search in trash or not. It would only make sense if you had a mix of contacts but I'm drawing a blank on where you can get that.

[eileenmcnaughton]

@demeritcowboy but at least it is notice-free pointlessness

[demeritcowboy]

Hehe, but on closer look, I think the notice-ful pointlessness was actually trying to tell us something. The field is really contact_is_deleted. Have made #25269