Deprecate meaningless parameter #25259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eileenmcnaughton
commented
Jan 2, 2023
| return $this->all($offset, $rowcount, $sort, FALSE, TRUE); | ||
| } | ||
| else { | ||
| return CRM_Core_DAO::singleValueQuery("SELECT contact_id FROM {$this->_tableName}"); |
There was a problem hiding this comment.
See - this returns the results of the query - not the sql itself... and if there is more than one row it ??? - which seems invalid
There was a problem hiding this comment.
OK - see comment on main PR thread - I made sense of it
|
Ah that explains it - full text search really doesn't use grup contact cache.... - so with this the behaviour is unchanged & works for PrevNextCache & unchanged & non-functional for GroupContact usage
|
c4ff7da to
4355339
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Deprecate meaningless parameter
Before
If
$returnSQLis passed in then the resulting sql is returned viaCRM_Core_DAO::composeQuery($sql);- However, this function leaves the sql unchanged if it is the only input parameter (it kicks into gear if$paramsis passed in as well)After
simplifed
Technical Details
A universe search suggests only one search has been implemented that overrides this function to use the variable - the full text search
I tried to make sense of the full text search - this function is called from 2 places
In the latter case the function would return an integer (a contact ID) - this possibly works because if makes invalid sql which gets caught by the try-catch (which would probably still be true). @lcdservices can maybe help here?
Comments
https://lab.civicrm.org/dev/core/-/issues/4056