[REF][PHP8.2] Avoid dynamic properties in civicrm_api3 class

[braders]

Overview

Avoid dynamic properties in civicrm_api3 class.

Before

Several properties set and retreived dynamically, which is deprecated in PHP 8.2. See https://lab.civicrm.org/dev/core/-/issues/3833 for context.

After

The properties are defined upfront, and are not dynamic.

Technical Details

• I made local public. It felt like there could be use-cases for third-party code to be able to see whether an API3 object is local or not. Furthermore, the property needs to be public as it is used in tests.
• input, lastResult, uri, key, api_key, referer and useragent are also public. Some of these are also used by tests, but I also gathered that given how widely used civicrm_api3 is in the ecosystem there may well be use-cases where these are being read. That said, I'm not sure we really want to be advertisting these as part of the public API, and so I have marked them as @internal.
• cfg and currentEntity felt very implementation specific and so have been made protected.

I've also changed the initial value of lastResult set in the constructor, to match the type it has elsewhere in the class (once the request has been made)

Happy to hear arguments for why any of these should change.

Comments

Reading through the code I couldn't really understand what $this->input is doing, and I suspect it's a bit buggy. Given everything is moving to APIv4 it probably doesn't warrant too much time spent looking into it, and for this PR I just wanted to get the dynamic properties righted out.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[braders]

Test this please

[seamuslee001]

This seems fine