Remove code for legacy php versions - assign_by_ref with an object
#25247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
eeadc68 to
a081223
Compare
|
Yeah if a tpl is intentionally changing the config or session then that's probably bad code that should be fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove code for legacy php versions -
assign_by_refwith an objectBefore
Use of assign_by_ref with objects is no different to assign in modern php - I believe this to be left over from our drive to support php4 at one point
After
poof
Technical Details
I'm tinkering with later smarty - which don't support assign_by_ref at all & none of our usages of it make sense
Comments