Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(NFC) When using @var annotations, ensure type comes first #25242

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

braders
Copy link
Contributor

@braders braders commented Dec 30, 2022

Overview

When using @var annotations, ensure type comes first.

See https://docs.phpdoc.org/3.0/guide/references/phpdoc/tags/var.html#var for details:

  1. The type should come first,
  2. When used with foreach blocks, it's more common to put the @var annotation outside the loop.

These changes will help IDEs use the information sensibly.

@civibot
Copy link

civibot bot commented Dec 30, 2022

(Standard links)

@civibot civibot bot added the master label Dec 30, 2022
@braders braders changed the title When using @var annotations, ensure type comes first (NFC) When using @var annotations, ensure type comes first Dec 30, 2022
@demeritcowboy demeritcowboy merged commit e619bd3 into civicrm:master Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants