Extract getMembershipBlock

[eileenmcnaughton]

Overview

Extract getMembershipBlock

Before

The code to getMembershipBlock is buried in a bigger if

After

It is extracted

Technical Details

Because the function now handles 'calculate if not already calculated' we can move it below the if which means we can also remove the get to grab it again a few lines further down. There is a legacy pattern where calculated values were passed around within the form & from form to form, either because they (incorrectly) thought the work involved in calculating them was enough to justify it or ... just cos. But in this case if you know the contribution page you can figure out the block - there is no dependency on the formValues

This is part of my effort to make sense of these variales #25181

Comments

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

thanks @mattwire