Update signature for searchKitTasks hook for civiimport

[mattwire]

Overview

Update signature for searchKitTasks hook for civiimport

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[mattwire]

This is not required for the fix. But it makes sense to update the signature at the same time..

[eileenmcnaughton]

@mattwire do we need to allow for NULL - you are adding a default so if not passed it will be [] & since these params are new there should be no cases of NULL actively being passed in

[mattwire]

I don't think so. It should either be unset or an array. The only edge case - but it doesn't get as far as the hook - is the other bit I'm fixing in this PR where the name is passed in as a string before being "expanded" into the array.

[eileenmcnaughton]

@mattwire so we can change to just array $search = [] rather than ?array $search = []?

[mattwire]

@eileenmcnaughton Yep, updated. I've rebased this PR so it's just a signature update now

[mattwire]

Also, turns out is does need the ?array because it can be NULL

[eileenmcnaughton]

@mattwire yeah - I just think we should convert it to an array before sending off to the hook - rather than this loosey goosey 'could be this could be that' approach

[colemanw]

@eileenmcnaughton they way this hook is called from different contexts, there's no way around the fact that sometimes those variables are set and sometimes they are not. However they will always be passed in, even if NULL, so @mattwire what I'd like to do with this PR is this:

Suggested change

	function civiimport_civicrm_searchKitTasks(array &$tasks, bool $checkPermissions, ?int $userID, ?array $search = [], ?array $display = []) {
	function civiimport_civicrm_searchKitTasks(array &$tasks, bool $checkPermissions, ?int $userID, ?array $search, ?array $display) {

[eileenmcnaughton]

@colemanw can I get you to take a look at this - it is a regression so we need to fix in the rc (currently 5.58). My issue is just where the values get typed along the way - it feels sloppy for the hook to have to handle it maybe being an array & maybe being null

@mattwire can you change the branch?

[mattwire]

@colemanw @eileenmcnaughton what do you want to do with this one?

[colemanw]

Happy anniversary to this PR! 🎈 🎉 🥳
I'm gonna close it because the params are unused so don't need to be added & none of us need to spend more of our brainpower on this.