Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] [merge custom fields] Only call function when applicable (well tested code) #25222

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

[REF] Only call function when applicable

Before

The function does an early return when called for non-custom fields

After

The function is not called for non-custom fields

Technical Details

Big whitespace change, small code change

Comments

@civibot
Copy link

civibot bot commented Dec 27, 2022

(Standard links)

@civibot civibot bot added the master label Dec 27, 2022
@eileenmcnaughton eileenmcnaughton changed the title [REF] Only call function when applicable (well tested code) [REF] [merge custom fields] Only call function when applicable (well tested code) Dec 27, 2022
@demeritcowboy
Copy link
Contributor

merge conflict

Big whitespace change as IF is moved
@eileenmcnaughton
Copy link
Contributor Author

@demeritcowboy rebased

@demeritcowboy demeritcowboy merged commit 85cdb10 into civicrm:master Jan 4, 2023
@eileenmcnaughton eileenmcnaughton deleted the cust_ed4 branch January 5, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants