Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] [merge custom fields function] Stop returning unaltered cFields parameter (good unit test cover) #25221

Merged
merged 1 commit into from
Dec 30, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Stop returning unaltered cFields parameter

Before

The cryptically named $cFields (parameter is returned unchanged from the function

After

The function does not return the unchanged variable & the calling code uses the value it already had

Technical Details

FWIW the 'c' stands for '$custom` - I will try to ensure we don't have this 'guess what I mean' variables by the end.

Comments

@civibot
Copy link

civibot bot commented Dec 26, 2022

(Standard links)

@civibot civibot bot added the master label Dec 26, 2022
@eileenmcnaughton eileenmcnaughton changed the title Stop returning unaltered cFields parameter [REF] [merge custom fields function] Stop returning unaltered cFields parameter (good unit test cover) Dec 27, 2022
@demeritcowboy demeritcowboy merged commit fb4f4b8 into civicrm:master Dec 30, 2022
@eileenmcnaughton eileenmcnaughton deleted the cust_ed3 branch December 30, 2022 21:52
@eileenmcnaughton
Copy link
Contributor Author

thanks @demeritcowboy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants