Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make event registration cancellation email optional for back office cancellation #25207

Conversation

larssandergreen
Copy link
Contributor

@larssandergreen larssandergreen commented Dec 20, 2022

Overview

Sometimes, you don't want to send a cancellation email when you cancel someone's registration. You can do this if you use Edit and change the status, but not if you use Transfer or Cancel.

Now, this is optional for back office users, though the default is to send an email, so no change to behaviour unless the user unchecks this option. Self-service cancellation users will not see this option and will always receive an email. No change for transfers.

Before

image

No option to not send email. Blanks for fee level and amount if not present.

image

If contact has no email, confusing status message.

After

image

Option to send email (default checked), only shown to back office users, when Cancel is selected and when the contact has an email. Fee level and amount are only shown if present (this change has also been made to the transfer form).

image

No message about email sent if no email has been sent. Confirmation says cancelled in first sentence for clarity.

Comments

I noticed the 'Cancellations are not refundable.' warning is not working, because the text for the cancel option has been changed and this function, for some reason, looks for the text of the option instead of the value. But I'm not sure it should be fixed and have added an issue on this.

@civibot
Copy link

civibot bot commented Dec 20, 2022

(Standard links)

@civibot civibot bot added the master label Dec 20, 2022
@larssandergreen larssandergreen force-pushed the make-email-for-registration-cancellation-or-transfer-optional branch from cb470bc to 1c6bc4e Compare December 20, 2022 20:51
@civicrm-builder
Copy link

Can one of the admins verify this patch?

@larssandergreen
Copy link
Contributor Author

jenkins test this please

1 similar comment
@larssandergreen
Copy link
Contributor Author

jenkins test this please

@mattwire mattwire merged commit d26e0d4 into civicrm:master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants