[REF][PHP8.2] Further resolve some deprecation issues around dynamic …

[seamuslee001]

…class properties

Overview

This fixes a few more PHP8.2 issues around dynamic class properties deprecations

Before

Deprecations triggered

After

Less Deprecations triggered

ping @eileenmcnaughton @demeritcowboy

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

Fatal error: Access level to CRM_Contact_Page_View::$_permission must be public (as in class CRM_Core_Page)

[seamuslee001]

ok that should be fixed now hopefully @demeritcowboy

[demeritcowboy]

As a sanity check I ran this little script to see if there were any classes redeclaring with different scopes for the ones that seemed likely:

files=`grep -l -r 'extends CRM_Core_Page' CRM`
for f in $files
do
  x=`grep _permission $f`;
  if [ -n "$x" ]; then
    echo "$f $x"
  fi
done

files=`grep -l -r 'extends CRM_Core_Form_Search' CRM`
for f in $files
do
  x=`grep _reset $f`;
  if [ -n "$x" ]; then
    echo "$f $x"
  fi
done

files=`grep -l -r 'use CRM_Contact_Form_Task_EmailTrait' CRM`
for f in $files
do
  x=`grep _contactDetails $f`;
  if [ -n "$x" ]; then
    echo "$f $x"
  fi
  x=`grep _entityTagValues $f`;
  if [ -n "$x" ]; then
    echo "$f $x"
  fi
  x=`grep _caseId $f`;
  if [ -n "$x" ]; then
    echo "$f $x"
  fi
  x=`grep _context $f`;
  if [ -n "$x" ]; then
    echo "$f $x"
  fi
done