PHP8: callback function on GOTV must be static

[MegaphoneJon]

Overview

The GOTV search page doesn't work, you get an error when you try to search.

Replication steps:

• Enable CiviCampaign.
• Create at least one Survey.
• Go to Campaigns menu » GOTV (Voter Tracking).
• Press Search.

Before

Endless spinning triangle, this error in the logs:

TypeError: call_user_func(): Argument #1 ($callback) must be a valid callback, non-static method CRM_Campaign_Page_AJAX::voterList() cannot be called statically in CRM_Utils_REST::process() (line 266 of /home/jon/local/civicrm-buildkit/build/dmaster/web/sites/all/modules/civicrm/CRM/Utils/REST.php).

After

Works.

Technical Details

callback functions need to be declared as static.

@jmcclelland You probably are interested in this patch.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).