SearchKit - Fix option loading & rendering for in-place edit #25197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes dev/core#4037
|
(Standard links)
|
| @@ -144,7 +144,7 @@ | |||
|
|
|||
| if (!_.includes(['>', '<', '>=', '<='], ctrl.op)) { | |||
| // Only use option list if the field has a "name" suffix | |||
| if (field.options && field.suffixes && field.suffixes.includes('name')) { | |||
| if (field.options && (!field.suffixes || field.suffixes.includes('name'))) { | |||
There was a problem hiding this comment.
Under what conditions would !field.suffixes be true?
There was a problem hiding this comment.
If the API call to getFields didn't include suffixes in the SELECT, then it would be missing. In that case I think we should assume do use the option list rather than don't, since most fields do support name.
|
Thanks! Tested and works. |
|
Merging based on @larssandergreen review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes dev/core#4037
Before
Can't edit-in-place select lists.
Console errors loading options.
After
Fixed.