Enhance metadata for OptionGroups #25188
Conversation
|
(Standard links)
|
| public static function getEditLink(array $field): string { | ||
| return "COALESCE( | ||
| (SELECT path FROM `civicrm_menu` WHERE path = CONCAT('civicrm/admin/options/', {$field['sql_name']})), | ||
| CONCAT('civicrm/admin/options/edit#/?gid=', `a`.`id`) |
There was a problem hiding this comment.
@aydun this is a very clever trick but I'm not entirely sold on the idea of these calc fields. Once we add something to the API there's an expectation that it will be supported in perpetuity, but this feels more like a temporary workaround to our messy menu situation. I feel like we just need to clean up the mess.
There was a problem hiding this comment.
Hi @colemanw, it is a temporary workaround/hack. What if we add it as deprecated/hidden/your-assignment-is-to-eliminate-me?
We have various different functions being carried out by CRM_Admin_Form_Options and CRM_Admin_Page_Options accessed by various URL's and some URL's that look like they should be handled by them but are actually handled by other classes. I was looking for a way to let us slide in SK versions and retire the old stuff rather than undertake what looks like an awkward revision of it first.
If we were to clean the mess, what structure would you opt for?
There was a problem hiding this comment.
Ok @aydun I want to put some thought into that but have family visiting for the holidays which is not conducive to the same, but I will try soon.
There was a problem hiding this comment.
No problem - I'm stopping in a day or so until New Year so no rush from me.
|
@aydun my proto-idea for how to tackle option groups is to actually embed the searchDisplay in a Smarty page instead of in an afform. That smarty page would preprocess similarly to the current one which extracts the option group id from the url, and then decides which columns the table needs hide depending on the shape of the option group, and sets the description of the search display based on the option group description. |
Extracted from civicrm#25180
|
@colemanw - as discussed, I've removed the calculated fields. Hopefully what's left is straightforward! |
|
Can one of the admins verify this patch? |
|
@civicrm-builder add to whitelist |
|
Thanks @aydun I've added the existing add/update paths. They might change in future but having them in metadata means we can update them without needing to update any search displays. |
|
Thanks @colemanw - makes sense. |
Overview
Enhance metadata for OptionGroups
Extracted from #25180
Note that the URLs
civicrm/admin/options/{edit,add,update}are created in other parts of that PR but will not adversely impact existing code.