totten/civix#257 Fix Civix not correctly loading Mixinx

[jaapjansma]

Overview

This is basically a fix for Civix. Civix had a mistake in the generated boilerplate causing to run the mixin only for the first installed extension.

Before

Mixin functions where only called once. So when a CiviCRM installation has multiple extensions the mixin functions where only called for one. Resulting in breaking functionality, such as not loading the xml/Menu/*.xml files.

After

The mixin functions are called for every extension. It loads it only once for each extension.

Comments

This is a fix to the boiler template used by Civix.

See as well: totten/civix#257

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

jenkins retest this please

[demeritcowboy]

I think something is wrong with the test nodes.

[totten]

Nice find, @jaapjansma! The analysis and patch look compelling. In its current context, __FUNCTION__ resolves to the non-unique expression {closure}. (Apparently, anonymous classes get unique __CLASS__ names, but anonymous functions don't get unique __FUNCTION__ names.)

We just need to get through testing.

(@demeritcowboy) I think something is wrong with the test nodes.

Yeah, I've noticed some similarly weird results recently on other PRs. Taking a look...

[seamuslee001]

Jenkins re test this please

[totten]

I've run the civix test-suite using the updated polyfill.php -- and deployed the extensions on top of 5.44 (where the polyfill is still needed). Confirmed the bug (before patch), and confirmed the fix (after patch). 👍

Looks good. Merging.

Related: totten/civix#279