[REF] Create Alter Column function in upgrade base class #25174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colemanw
reviewed
Dec 14, 2022
CRM/Upgrade/Incremental/Base.php
Outdated
| if ($localizable) { | ||
| if ($locales) { | ||
| foreach ($locales as $locale) { | ||
| $queries[] = "ALTER TABLE `$table` CHANGE `{$column}_{$locale}` `description_{$locale}` $properties"; |
There was a problem hiding this comment.
Suggested change
| $queries[] = "ALTER TABLE `$table` CHANGE `{$column}_{$locale}` `description_{$locale}` $properties"; | |
| $queries[] = "ALTER TABLE `$table` CHANGE `{$column}_{$locale}` `{$column}_{$locale}` $properties"; |
colemanw
reviewed
Dec 14, 2022
CRM/Upgrade/Incremental/Base.php
Outdated
Comment on lines
591
to
592
| if ($localizable) { | ||
| if ($locales) { |
There was a problem hiding this comment.
These two if statements could be combined to
Suggested change
| if ($localizable) { | |
| if ($locales) { | |
| if ($localizable && $locales) { |
Minor fixes as per coleman
c948fab to
f2cbacf
Compare
|
thanks @colemanw I think I have patched up both things now |
|
thanks @demeritcowboy @colemanw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This creates an alterColumn function similar to that of addColumn and refactors the upgrade code from #25143 to use the new method
Before
No standard method for modifying columns in the database during upgrades
After
One standard method
ping @colemanw