[dev/core#3470] Search Kit: Mailing labels don't work #25164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alifrumin Style check failures. |
| ]; | ||
|
|
||
| //break out mailing labels for redirect instead of crmPopup | ||
| if ($task['title'] == 'Mailing labels - print') { |
There was a problem hiding this comment.
I haven't run this but I think it would be better to check the loop index $id, to be more translation-friendly. if $id == CRM_Core_Task::LABEL_CONTACTS
There was a problem hiding this comment.
good suggestion just updated the code
colemanw
reviewed
Dec 14, 2022
| $tasks[$entity['name']]['contact.' . $id] = [ | ||
| 'title' => $task['title'], | ||
| 'icon' => $task['icon'] ?? 'fa-gear', | ||
| 'crmPopup' => [ |
There was a problem hiding this comment.
It appears the only difference between these 2 blocks of code is this one line 'crmPopup' vs. 'redirect'. That could be a variable. Like
// Print Labels action does not support popups, open full-screen
$actionType = $id == CRM_Core_Task::LABEL_CONTACTS ? 'redirect' : 'crmPopup';
There was a problem hiding this comment.
That does make for a smaller more elegant code change, thanks @colemanw
|
@civicrm-builder retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When one creates a SearchKit Search for the "Contacts" entity the Actions dropdown includes an option: "Mailing labels - Print". This action is broken. This PR fixes it. More details can be found on this issue: https://lab.civicrm.org/dev/core/-/issues/3470.
Before
The Search Kit action "Mailing labels - Print" for contact searches does NOT work.
After
The Search Kit action "Mailing labels - Print" for contact searches work.