Configure Event Fees tab #25120
Merged
Configure Event Fees tab #25120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
jenkins retest this please. |
|
jenkins retest this please |
| @@ -66,7 +66,14 @@ public static function process(&$form) { | |||
| $tabs = []; | |||
| $tabs['settings'] = ['title' => ts('Info and Settings'), 'class' => 'ajaxForm livePage'] + $default; | |||
| $tabs['location'] = ['title' => ts('Event Location')] + $default; | |||
| $tabs['fee'] = ['title' => ts('Fees')] + $default; | |||
| // Check to see if CiviContribute is an enabled component. | |||
| $components = \Civi\Api4\Setting::get() | |||
There was a problem hiding this comment.
The helper Civi::settings()->get('enable_components') is a little pithier (we also support that for extensions/outside core)
| ->addSelect('enable_components') | ||
| ->execute()[0]['value']; | ||
| // If CiviContribute is active, create the Fees tab. | ||
| if (in_array('CiviContribute', $components)) { |
There was a problem hiding this comment.
Actually - even pithier....
if (CRM_Core_Component::isEnabled('CiviContribute')) {
There was a problem hiding this comment.
Thank you @eileenmcnaughton - that is much pithier! I've modified the code to use that helper instead of the API call to achieve the conditional logic.
|
Code makes sense - there is a helper |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes the Fees tab on the Configure Event page - as well as the link to the Fees page from the Configure button on an event - conditionally dependent on whether CiviContribute is enabled. This will prevent users from trying to set up a paid event when the Component that allows payment processing is not active.
Before
Previously, if the CiviContribute Component was disabled, the Configure Event page included the Fees tab, which would allow users to try to set up a paid event. However, users would receive an error because without CiviContribute, there are no Financial Types for a user to select from.
After
With this PR, the Fees tab and its corresponding link on the Configure menu of an event are not displayed if CiviContribute is disabled. (CiviContribute can be disabled by going to Administer > System Settings > Components, unchecking the box next to the component's name, and clicking Save.)
Technical Details
While ideally one shouldn't repeat themselves in code, since the code that controls the tab and the link are housed in two different classes, I made the same changes to both files; wrapping the line(s) of code that generate the Fees tab/link in an
ifblock that is only entered if CiviComponent is within the['value']array returned by an APIv4 call to theenable_componentsSetting entity.