Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DebugSubscriber - Fix activation check #25105

Merged
merged 1 commit into from
Dec 3, 2022
Merged

Conversation

totten
Copy link
Member

@totten totten commented Dec 3, 2022

Backport #24554 (circa 5.54+) to 5.45. This should make it is easier to test civix with prior ESR and current build-environment.

This subscriber only interjects if XDebug is configured with the suitable mode.

To see if the mode is suitable, it consults `ini_get("xdebug.mode")`, but
this is not quite right -- because the mode may be set other ways (eg
`XDEBUG_MODE`). In XDebug 3.1+, you can get the true effective-mode
by calling `xdebug_info`.

See also: https://xdebug.org/docs/all_functions#xdebug_info
@civibot
Copy link

civibot bot commented Dec 3, 2022

(Standard links)

@civibot civibot bot added the 5.45 label Dec 3, 2022
@totten
Copy link
Member Author

totten commented Dec 3, 2022

Test failure unrelated.

@totten totten merged commit 845e637 into civicrm:5.45 Dec 3, 2022
@totten totten deleted the 5.45-xdebug branch December 3, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant