Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php 8] Update pear/mail to 1.5 #25092

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

demeritcowboy
Copy link
Contributor

@demeritcowboy demeritcowboy commented Nov 30, 2022

Overview

Some php 8 warnings. See pear/Mail@368c52f

Before

preg_replace doesn't like null

After

preg_replace ok with '', until php decides that's not ok either and then we have to update again.

Technical Details

You won't see these in unit tests mostly because the mailer doesn't use smtp. In another environment where tests do, this comes up 1000s of times in the core tests. I couldn't figure out where they were coming from since locally it doesn't use smtp either, and then they magically went away today, and tracked it down to this being released today.

Comments

This also includes pear/Mail@66ac6d1 which is the only thing that stood out from: pear/Mail@v1.4.1...v1.5.0, and it looks like @MegaphoneJon liked it. I'll note also that as of today new drupal 9 installs will automatically get 1.5 regardless of the change here.

@civibot
Copy link

civibot bot commented Nov 30, 2022

(Standard links)

@MegaphoneJon
Copy link
Contributor

@demeritcowboy I almost submitted this today - but then I thought it was unnecessary because the version was ^1.4. But I guess a) we should be explicit, b) we still need to update composer.lock. Anyway, you can consider this reviewed - I also looked over all the commits since 1.4.1 and have it running in production on 1-2 D9 sites already (plus one WP site where just today I needed the "use STARTTLS on unauthenticated connections" functionality).

@demeritcowboy
Copy link
Contributor Author

jenkins retest this please - looks like mysql weirdness

@demeritcowboy
Copy link
Contributor Author

Test fail is that unrelated date-sensitive test fail that's been coming up. Thanks @MegaphoneJon @seamuslee001

@demeritcowboy demeritcowboy merged commit 25230dc into civicrm:master Dec 1, 2022
@demeritcowboy demeritcowboy deleted the pear-mail branch December 1, 2022 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants