Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Some php 8 warnings. See pear/Mail@368c52f
Before
preg_replace doesn't like null
After
preg_replace ok with
''
, until php decides that's not ok either and then we have to update again.Technical Details
You won't see these in unit tests mostly because the mailer doesn't use smtp. In another environment where tests do, this comes up 1000s of times in the core tests. I couldn't figure out where they were coming from since locally it doesn't use smtp either, and then they magically went away today, and tracked it down to this being released today.
Comments
This also includes pear/Mail@66ac6d1 which is the only thing that stood out from: pear/Mail@v1.4.1...v1.5.0, and it looks like @MegaphoneJon liked it. I'll note also that as of today new drupal 9 installs will automatically get 1.5 regardless of the change here.