SearchKit - Fix crashy-ness when an Afform contains a deleted search #25091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Jenkins re test this please |
|
Test failures are unrelated |
|
when looking at this in ignore whitespace mode https://github.com/civicrm/civicrm-core/pull/25091/files?w=1 it makes it a lot more obvious what is going on here and seems fine to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes crash when trying to load an Afform that contains a SavedSearch which has been deleted.
Before
Hard crash if a SavedSearch embedded in an Afform cannot be found. I tested this by embedding a Search in a form (using the default table display), then deleting it without deleting the form. Caused random system crashes even on non-afform pages.
After
No crash.
Technical Details
Lots of whitespace changes but the only functional difference is to add try/catch.