FieldSpec - Generate better default field titles for DAOs

[colemanw]

Overview

Improves autogenerated field titles, beneficial for some extensions.

Before

Fields with id or is in their name don't get a default title; confusing code comment incorrectly asserts that they shouldn't have one.

After

Every field gets a title.

Technical Details

I stumbled across this when adding metadata to CiviDiscount. Normally when you generate a DAO from the xml, any field without a <title> will get an autogenerated one based splitting and uc_words-ing the <name>. However, I noticed that some fields were getting autogenerated titles and others weren't... I finally traced it to this function that boldly (but incorrectly) asserts "id's do not get titles". That's not true; every field in the core schema has a title, in fact after making this change and regenerating all core DAOs... nothing changed. So apparently after making a function to deliberately not make titles for those fields, we then spent years diligently working around it by manually adding <title> to every field!

So even though this has no apparent impact on core, it's good to have anyway and now fields in Extensions will consistently have titles. With this change I re-ran civix generate:entity-boilerplate for CiviDiscount and was rewarded with this: https://lab.civicrm.org/extensions/cividiscount/-/merge_requests/282/diffs

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Unrelated fails