dev/core#2898 - Add handling to token processor for double http in url tokens

[eileenmcnaughton]

Overview

Add handling to token processor for double http in url tokens

Before

If a user uses ckeditor to create text they are likely to create a string like

https://{contact.website_first.url}

which renders to

https://https://example.com

After

A new tidy class fixes this specific string

Technical Details

This was the last thing that Flexmailer did that the old BAO class didn't - with this done we can make flexmailer compulsory and remove the legacy code.

Comments

I tried to keep this really simple & avoid getting drawn into to anything that would result in 'clever code' - partly cos I'm feeling a bit of code-magic ptsd at the moment - but also because this feature that someone probably spend an hour adding to the BAO mailer has already cost us probably weeks or time & delayed flexmailer substantially so I just want to keep it simple, get it wrapped up,

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[totten]

I just want to keep it simple

👍 I agree, this implementation looks pretty straight to me. Test-coverage is good. I did some r-run (comparing my local, which has the problem -- against the autobuild site, where it's fixed), and that looked good too

Merging!