Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add noisy deprecation to getContactTokenReplacement #25077

Merged
merged 1 commit into from
Dec 1, 2022
Merged

Add noisy deprecation to getContactTokenReplacement #25077

merged 1 commit into from
Dec 1, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Nov 29, 2022 •
edited
Loading

Overview

Add noisy deprecation to getContactTokenReplacement

Before

Function only called in core from places that already have their own noisy deprecation

image

After

Noisy deprecation added - full removal to be done later

Technical Details

Comments

@civibot
Copy link

civibot bot commented Nov 29, 2022

(Standard links)

@civibot civibot bot added the master label Nov 29, 2022
@eileenmcnaughton eileenmcnaughton changed the title Add noisy deprecation to getContactTokenReplacement Add noisy deprecation to getContactTokenReplacement Nov 29, 2022
@yashodha
Copy link
Contributor

yashodha commented Dec 1, 2022

@eileenmcnaughton merging this

@yashodha yashodha merged commit a3de877 into civicrm:master Dec 1, 2022
@eileenmcnaughton eileenmcnaughton deleted the token_deprecation branch December 3, 2022 02:13
@eileenmcnaughton
Copy link
Contributor Author

thanks @yashodha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @yashodha