Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query to use standard CRM_Core_DAO::executeQuery #25075

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Fix query to use standard CRM_Core_DAO::executeQuery

Before

Query uses the legacy (and leaky)

 $eq = new CRM_Core_DAO();
  $eq->query()

As a result it does some convoluted table look ups as it is not benefitting from the localisation handling in CRM_Core_DAO::executeQuery

After

Standardised to CRM_Core_DAO::executeQuery

Technical Details

I had a go at this once before but as @seamuslee001 pointed out I rushed it & made mistakes - https://github.com/civicrm/civicrm-core/pull/24446/files - I'm re-doing it with the benefit of the test @seamuslee001 wrote & have also gone for the least ambitious change in the first instance (looking into the rest now)

Comments

Anything else you would like the reviewer to note

@civibot
Copy link

civibot bot commented Nov 29, 2022

(Standard links)

@civibot civibot bot added the master label Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants