Add FormBuilder forms to Civiimport

[eileenmcnaughton]

Overview

Add FormBuilder forms to Civiimport

Before

Without FormBuilder wrappers we can't embed the forms

After

Now we can...

Technical Details

Comments

@colemanw - these are created if Civiimport is enabled when importing

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Unrelated fail

Test Result (2 failures / ±0)
api_v3_OrderTest.testAddOrderForMembershipWithDates with data set #6
api_v3_OrderTest.testAddOrderForMembershipWithDates with data set #13

[colemanw]

@eileenmcnaughton unless I'm missing something, all this can be simplified. You don't need the per-user caching & you don't need the permission check when fetching SearchDisplays and you don't need the try/catch.

[eileenmcnaughton]

@colemanw yeah - you do want all that - the user will only retrieve their own jobs by the acls - so it is per user. And if they don't have permission to the api at all then we want to catch the error

[colemanw]

Ok so is there some hidden mechanism checking permissions inside the SearchDisplay::get() that only returns certain searches per-user?

[eileenmcnaughton]

Yeah - cos it applies ACLs & the ACLS on the UserJob filter

[eileenmcnaughton]

@colemanw I've addressed your feedback (and confirmed the docs step-by-step guide on how to embed a form is inadequate.... https://docs.civicrm.org/dev/en/latest/afform/overview/#embedding )

[colemanw]

@eileenmcnaughton I've expanded the docs to be slightly more adequate. The code snippets are untested so will need to be adjusted as we go along.

[eileenmcnaughton]

@colemanw - I'll see if I can make sense of it - this will be less painful to work on if we put 'My imports' in navigation - do you think under 'Reports' - it's the best I can think of

[colemanw]

Ok @eileenmcnaughton I'm fine with you merging this whenever you're ready

[eileenmcnaughton]

@colemanw yeah - I'm ready on this one - the other is slated as a follow up (embedding)

[eileenmcnaughton]

@colemanw OK - having sume success with - 301c8de

[eileenmcnaughton]

Upgraded to Merge-on-pass based on above comment & because I don't intend to add more to this PR