fix numfmt error when pager limit is set in Civi settings #25070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
I think this ought to go into 5.46 |
|
@colemanw I don't have a DeLorean, but re: 5.56 - I'm not sure that this actually causes a change in functionality and it's not a regression. Unfortunately, I discovered three separate bugs while testing this form, so it's a bit much to disentangle. I made a Gitlab ticket for the second one, and will work on the third one tomorrow. |
|
jenkins retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
If you set a default pager limit in the Search Preferences screen, SearchKit will display this error in console when selecting contacts to take an action on:
Before
Error.
After
No error.