Make MessageTemplate.master_id fully joinable #25056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move Calculated Field tests out of BAO tests - they're not BAO Enhance test to check fields of master_id entity are returned.
|
(Standard links)
|
colemanw
reviewed
Nov 27, 2022
| @@ -23,7 +23,7 @@ public function modifySpec(RequestSpec $spec) { | |||
| ->setInputType('Select') | |||
| ->setReadonly(TRUE) | |||
| ->setFkEntity('MessageTemplate') | |||
| ->setSqlRenderer([__CLASS__, 'revertible']); | |||
| ->setSqlRenderer(['\Civi\Api4\Service\Schema\Joiner', 'getExtraJoinSql']); | |||
There was a problem hiding this comment.
Nice to see this function getting some reuse!
|
Well done @aydun - this is top-notch API work. |
|
Thanks @colemanw - I realised that was your 'secret sauce' for avoiding duplicating the query when the calculated field is an entity ref. |
|
LOL, I probably should have documented that sauce rather than keeping it secret. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to #24992
Overview
Make MessageTemplate.master_id fully joinable
Before
MessageTemplate.master_idreturned the id of the master template (ie the core distributed one)But fields of the master template like
MessageTemplate.master_id.msg_subjectwere not returned.After
Fields of the master template like
MessageTemplate.master_id.msg_subjectare returned.Technical Details
Also moves tests out of the BAO class since these fields are not in the BAO. Enhanced tests
Comments
@colemanw