Remove legacyCreateMultiple function #25048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
@eileenmcnaughton there's a MC |
This was annotated deprecated 7 years ago, is called 'legacy' and was nosily deprecated 10 months ago. It IS still called from one jma extenion but I think it's OK to remove with a ping
b5151f6 to
b45959f
Compare
|
@colemanw fixed |
|
@eileenmcnaughton merging this. Thanks! |
|
Yay - thanks @yashodha - nice to see these things do eventually die |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove legacyCreateMultiple function
This was annotated deprecated 7 years ago, is called 'legacy' and was nosily deprecated 10 months ago. It IS still called from one jma extenion but I think it's OK to remove with a ping
Before
After
poof
Technical Details
@JoeMurray @seamuslee001 - jmagrantapplications is the only universe usage of this function
Comments