Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menubar - Fix buggy, slow loader #25012

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

colemanw
Copy link
Member

Overview

While testing CiviCRM in Drupal 9 I found that the menubar doesn't load consistently. This is because the javascript that waits for #civicrm-container to be present does so in a slow, convoluted way. This simplifies the code and eliminates the bugginess.

Before

Menubar loads inconsistently.

After

Loads every time, and more efficiently.

Technical Details

This function is supposed to be fast, yet was using lo-dash and jQuery to do things that are much faster to do with vanilla javascript.

@civibot
Copy link

civibot bot commented Nov 21, 2022

(Standard links)

@civibot civibot bot added the master label Nov 21, 2022
@demeritcowboy demeritcowboy merged commit 488582e into civicrm:master Nov 23, 2022
@demeritcowboy
Copy link
Contributor

I don't notice any difference before or after so 🐎

@colemanw colemanw deleted the civiMenuCleanup branch November 23, 2022 15:37
@colemanw
Copy link
Member Author

Thanks @demeritcowboy!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants