Menubar - Fix buggy, slow loader #25012
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
While testing CiviCRM in Drupal 9 I found that the menubar doesn't load consistently. This is because the javascript that waits for
#civicrm-container
to be present does so in a slow, convoluted way. This simplifies the code and eliminates the bugginess.Before
Menubar loads inconsistently.
After
Loads every time, and more efficiently.
Technical Details
This function is supposed to be fast, yet was using lo-dash and jQuery to do things that are much faster to do with vanilla javascript.