php8 - don't pass null as string #25007
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Some deprecations
Before
htmlentities(): Passing null to parameter #1 ($string) of type string is deprecated
mysqli_real_escape_string(): Passing null to parameter #2 ($string) of type string is deprecated
After
Technical Details
These should be coming up during tests/phpunit/CRM/Core/DAOTest.php, but the mysqli one gets hidden by the
@
in pear/db/myqli, and the other one I dunno what's hiding it. When I run it in a different test environment they show up as deprecations (not fails, but listed separately as deprecations). It think it's phpunit-bridge that shows it.Comments