Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php8 - don't pass null as string #25007

Merged
merged 1 commit into from
Nov 20, 2022
Merged

Conversation

demeritcowboy
Copy link
Contributor

Overview

Some deprecations

Before

  • htmlentities(): Passing null to parameter #1 ($string) of type string is deprecated
  • mysqli_real_escape_string(): Passing null to parameter #2 ($string) of type string is deprecated

After

Technical Details

These should be coming up during tests/phpunit/CRM/Core/DAOTest.php, but the mysqli one gets hidden by the @ in pear/db/myqli, and the other one I dunno what's hiding it. When I run it in a different test environment they show up as deprecations (not fails, but listed separately as deprecations). It think it's phpunit-bridge that shows it.

Comments

@civibot
Copy link

civibot bot commented Nov 19, 2022

(Standard links)

@civibot civibot bot added the master label Nov 19, 2022
@demeritcowboy
Copy link
Contributor Author

Noting that the deprecations do appear in the output at #25009 (comment)

@colemanw colemanw merged commit a5de1b2 into civicrm:master Nov 20, 2022
@demeritcowboy demeritcowboy deleted the daotest2 branch November 20, 2022 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants