More del() deprecations in favour of standard deleteRecord()

[aydun]

Overview

Follow on to #24999

This is a bit mechanical so please review the diffs.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[colemanw]

Thanks! Just to clarify, the pattern is to move any extra logic from the del function into hooks. In the first file of the PR, extension del contains nothing but the delete itself, so there's nothing to move. That file doesn't need a hook and doesn't need to implement HookInterface

[colemanw]

All looks good. Thanks for working on this @aydun

[aydun]

@colemanw Can you see why this is failing? From the stack trace, it seems to be doing the expected things. It gets to deleteRecord() for MailingAB, then the post hook fires and tries to call deleteRecord() on the Mailings that are mailing_id_a, mailing_id_b and mailing_id_c but fails on one of those.

[colemanw]

@aydun well the difference is that you've changed it from calling $obj->delete() on each mailing part over to using deleteRecord(). The latter throws an exception if it fails, the former does not. So the unit test may have had faulty data and no one ever noticed. I guess we could get parity by wrapping each call in a try/catch block....

Or we could punt and change them back to using $obj->delete() inside the post hook.

[eileenmcnaughton]

Might be easier to pull out that BAO from this & handle on it's own

[aydun]

Ok, MailingAB moved out of here to #25024

[aydun]

Same error by a different path.... I'll move Mailing as well

[eileenmcnaughton]

Well that got this one merged :-)