Sentence runs together since period is inside the if block

[demeritcowboy]

Overview

It should be outside the if.

Before

1. Add a profile to a contribution page that allows user signup (in the advanced profile settings - under account creation).
2. Visit the contribution page. Depending on the cms config, the if block will show or not. If it doesn't show, then there's no period and the first sentence runs right into the next one: If you would like to create an account on this site, check the box below and enter a Username If you already have an account please login before completing this form.

After

Better

Technical Details

Comments

Came up during review of #25002

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[demeritcowboy]

It's not really translation-friendly either before or after. I should put up an alternate.

[colemanw]

This is an example of "too clever" programming. Translatability is best when code is really dumb and doesn't try to put sentence fragments together. I think there needs to be 2 versions of the entire sentence, not 2 half-sentences joined together.

[demeritcowboy]

Yeah I started looking and should also fix the empty() while I'm there.

[demeritcowboy]

Alternate: #25005