improve social sharing footer

[kurund]

No description provided.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

@vingle do you have any thoughts here as I know you did some cleanup on this previously

[vingle]

I've no strong feelings about it – happy to ok any of Kurund's changes.

But I am curious why swap 'share on Facebook/LinkedIn' for 'Facebook/LinkedIn' and 'Tweet' for 'Twitter'? The links are not pointing at the social media accounts, but to the share function on each social network.. ie they perform the function 'share'.

If I'm on a site and see 'Twitter' 'LinkedIn' 'Facebook' etc, I assume the link is going to take me to that's site's social media accounts. I'd need the words 'share/toot/tweet/publish/broadcast/etc' to know that's what the link would do.

[kurund]

But I am curious why swap 'share on Facebook/LinkedIn' for 'Facebook/LinkedIn' and 'Tweet' for 'Twitter'? The links are not pointing at the social media accounts, but to the share function on each social network.. ie they perform the function 'share'.

If I'm on a site and see 'Twitter' 'LinkedIn' 'Facebook' etc, I assume the link is going to take me to that's site's social media accounts. I'd need the words 'share/toot/tweet/publish/broadcast/etc' to know that's what the link would do.

The whole section is about sharing, hence I thought of simplifying the same. I do understand your point. I have added title so on hover it will prompt Share, Tweet or Email.

Let me know if that helps!

[vingle]

Let me know if that helps!

Looks great, a good idea to add that in the title.

[yashodha]

@kurund also would be great to squash the commit once done. Thanks!

[kurund]

@kurund also would be great to squash the commit once done. Thanks!

Done.

[eileenmcnaughton]

My take on this is that the above conversation endorses this change - merging