Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid symbol scan errors in oauth-client help text #24998

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

demeritcowboy
Copy link
Contributor

Overview

Errors while scanning for symbols.

Before

  1. Install oauth-client
  2. On almost every page you get User warning: htmlParseEntityRef: no name in Civi\Afform\Symbols::scan() (line 46 of ...\ext\afform\core\Civi\Afform\Symbols.php)
  3. I think it shows up more in-your-face with php 8.1 but it would have been there before too just not as loud.

After

Technical Details

It doesn't seem to like some unescaped html symbols like > and &.

I wasn't 100% sure about the first one but it seems to evaluate correctly. You can see the text if you go to Administer - system settings - oauth, and then e.g. click on google and then on the register tab.

Comments

@civibot
Copy link

civibot bot commented Nov 18, 2022

(Standard links)

@civibot civibot bot added the master label Nov 18, 2022
@eileenmcnaughton
Copy link
Contributor

@demeritcowboy this seems to fix the errors for me.

However, I hit them on the 5.56 rc so I think we should target that branch

@totten totten merged commit a93ed69 into civicrm:master Dec 7, 2022
@demeritcowboy demeritcowboy deleted the oauth-name branch December 7, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants