Remove php8-specific coding pattern #24952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
|
Um. what ? Typed properties came in in 7.4! @eileenmcnaughton |
|
@artfulrobot ah ok - but either way - above our min supported version |
|
@eileenmcnaughton wow, sorry, didn't know we had to support 7.2 (which hasn't had security updates for over 2 years) still (I'm not saying this information is hard to find, just that I forget). Thx for clarification. |
|
@artfulrobot yeah - that reminds me - we were thinking of making the next ESR the last 7.2 version - I should create a ticket / put in dev-digest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm gonna self-merge this asap so no-one else hits it - the PR that caused it was only just merged
@artfulrobot - even if you are using php8 your IDE can be told to think of it as php 7.3.... (PhpStorm can anyway)