Add tests for importing county (includes adding v4 County api) #24919

eileenmcnaughton · 2022-11-08T01:54:54Z

Overview

I was attempting to address the issue @jmcclelland is showing here #24917 - but I found that the tests passed, once I had addressed 2 issues with it

Caching - this was the main one - the option values are cached
The csv - after I fixed ^^ I found the csv checks for the same values on the related contact as the main contact

fix typo in county name in test.

civibot · 2022-11-08T01:54:57Z

(Standard links)

If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

The previous test was failing due to cached values not being cleared by the sql insert

add test for detecting failed county import by name.

d42fd59

fix typo in county name in test.

civibot bot added the master label Nov 8, 2022

eileenmcnaughton mentioned this pull request Nov 8, 2022

Import county #24917

Closed

Add County api & fix test to use it

00f559e

The previous test was failing due to cached values not being cleared by the sql insert

eileenmcnaughton force-pushed the import_county branch from f1ec78d to 00f559e Compare November 8, 2022 02:00

eileenmcnaughton changed the title ~~Add tests for importing county~~ Add tests for importing county (includes adding v4 County api) Nov 8, 2022

eileenmcnaughton added the has-test label Nov 9, 2022

colemanw merged commit ca1af4c into civicrm:master Nov 9, 2022

colemanw deleted the import_county branch November 9, 2022 22:00