dev/core#3952 Add in Upgrade script to fix up print labels where " wa…

[seamuslee001]

…s not being properly escaped for json purposes on previous upgrade process

Overview

This aims to replicate the fix that was put in for new installs in #24695 but this does this for sites that had upgraded using hte previous upgrade step.

Before

Print labels in already installed sites may not be able to be json_decoded properly due to date upgrade issue

After

Should be fixed now

ping @eileenmcnaughton @totten @demeritcowboy

[civibot]

No issue was found matching the number given in the pull request title. Please check the issue number.

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

Happily some other testing I've been doing means my db is already in the 'pre' state for this PR

Hmm - but I think the function version needs to change

[eileenmcnaughton]

testing

• public function upgrade_5_55_0($rev): void {

• public function upgrade_5_55_alpha2($rev): void {
  $this->addTask(ts('Fix Event Badge Upgrade'), 'fix_event_badge_upgrade');
  $this->addTask(ts('Upgrade DB to %1: SQL', [1 => $rev]), 'runSql', $rev);

[eileenmcnaughton]

no - it wasn't that easy

[eileenmcnaughton]

Looks like it ran the update though....

[eileenmcnaughton]

Same issue in the test run

Dropping SQL triggers...
Preparing upgrade...

In Form.php line 509:

[CRM_Core_Exception]
Malformed upgrade sequence. The incremental update 5.55.0 exceeds target v
ersion 5.55.beta1

Exception trace:
at /home/jenkins/bknix-dfl/build/core-24872-1wqd2/web/sites/all/modules/civicrm/CRM/Upgrade/Form.php:509
CRM_Upgrade_Form::buildQueue() at phar:///home/jenkins/bknix-dfl/bin/cv/src/Command/UpgradeDbCommand.php:117
Civi\Cv\Command\UpgradeDbCommand->execute() at phar:///home/jenkins/bknix-dfl/bin/cv/vendor/symfony/console/Command/Command.php:255