dev/core#3850 Fix checkboxes handling for custom fields in contact import

[eileenmcnaughton]

Overview

dev/core#3850 Fix checkboxes handling for custom fields in contact import

Before

Per https://lab.civicrm.org/dev/core/-/issues/3850 multiple item checkboxes are mis-saved in Contact import

After

Save correctly (description on gitlab of steps)

Technical Details

This code has 'evolved' from what was originally probably a copy & paste of the form layer. The function formatProfileContact was used to to prepare values that had been lovingly crafted into form-like format to be passed to the `BAO_Contact::create'.

Over time the function started to call the api instead of Contact::create making much of what was happening in formatProfileContact redundant. Because that function was serving multiple masters & crazy-complex a copy of the function was taken & it was moved onto the import class where we could start to unravel it (knowing ti would only affect import). However the function still contains much code that grew up for it's other use-cases, rather than import.

Paralell to that $params = $this->getMappedRow($values); evolved into a function which generally took the input & returned it in an api-ready format.

Hence the go-to solution for any import data format related issues is to try removing code :-)

In this case the worker function CRM_Core_BAO_CustomField::formatCustomField is already called in the api - but along the way handing was added for exactly this type of field - so if we just let the api do the work the bug is fixed

Comments

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[jmcclelland]

Thank you @eileenmcnaughton! I love fixing problems by deleting code :).

I just tested this change against 5.51.3 (on a site previously experiencing the problem) and it worked perfectly after applying this patch.

[andyburnsco]

Confirmed this also works on 5.54.0. Thanks @eileenmcnaughton :)