Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove never-changing variable #24816

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

CRM_Utils_Address::formatMailingLabel is called from 3 places in the code & I found none in the rest of universe. Of those 3
all pass the same values for $mailing - ie TRUE. This PR removes the usage of that variable - such that it is assumed to be TRUE (as this stage the signature is unchanged)

image

Before

Always true variable passed in

After

Variable no longer relevant - the test instance no longer passes the unused params but the others still do as $tokens at the end is still populated

image

Technical Details

Comments

@civibot
Copy link

civibot bot commented Oct 25, 2022

(Standard links)

@civibot civibot bot added the master label Oct 25, 2022
@eileenmcnaughton
Copy link
Contributor Author

test this please (issue seems to be sql-went-away)

@eileenmcnaughton
Copy link
Contributor Author

test this please

@seamuslee001
Copy link
Contributor

@eileenmcnaughton can you rebase

@eileenmcnaughton
Copy link
Contributor Author

@seamuslee001 done

@seamuslee001 seamuslee001 merged commit 5165b63 into civicrm:master Oct 26, 2022
@seamuslee001 seamuslee001 deleted the label_unused branch October 26, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants