Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
CRM_Utils_Address::formatMailingLabel
is called from 3 places in the code & I found none in the rest of universe. Of those 3all pass the same values for
$mailing
- ie TRUE. This PR removes the usage of that variable - such that it is assumed to be TRUE (as this stage the signature is unchanged)Before
Always true variable passed in
After
Variable no longer relevant - the test instance no longer passes the unused params but the others still do as
$tokens
at the end is still populatedTechnical Details
Comments