Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Add in Unit test to demonstrate error when trying to import a c… #24814

Merged

Conversation

seamuslee001
Copy link
Contributor

…ampaign id int rather than name or label of the campaign

Overview

@eileenmcnaughton as discussed this shows the problem when importing a contribution with campaign id rather than the campaign label

Before

No test

After

Test

ping @andrew-cormick-dockery @johntwyman just FYI

@civibot
Copy link

civibot bot commented Oct 25, 2022

(Standard links)

@civibot civibot bot added the 5.55 label Oct 25, 2022
…ampaign id int rather than name or label of the campaign
@seamuslee001
Copy link
Contributor Author

Test fails as expected without #24815

@andrew-cormick-dockery
Copy link
Contributor

I'd add tests for:

  • name
  • title
  • failure text - intentionally fail, examine text upon failure.

@seamuslee001
Copy link
Contributor Author

Jenkins re test this please

1 similar comment
@seamuslee001
Copy link
Contributor Author

Jenkins re test this please

@eileenmcnaughton eileenmcnaughton merged commit f864ecd into civicrm:5.55 Oct 26, 2022
@eileenmcnaughton eileenmcnaughton deleted the failing_test_campaign_id branch October 26, 2022 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants