CRM_Admin_Form - Support standalone forms #24770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type of form was traditionally embedded in a page, with values like _id and _action `set()` by the page controller. This allows Admin forms to be placed at their own url without any refactoring.
|
(Standard links)
|
|
flagged as merge ready as code seems fine just needs an r-run |
|
I was thinking extensions that extend CRM_Admin_Form might have to make some modifications but it seems ok as-is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This allows Admin forms to be placed at their own url without any refactoring.
Before
Preprocess function only works if form is embedded in a page.
After
Works either way
Technical Details
This type of form was traditionally embedded in a page, with values like _id and _action
set()by the page controller.