AdminUI - Always cleanup saved searches during uninstall #24760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This sets all AdminUI saved searches to be delted during uninstall, for a cleaner uninstall process. It also sets cleanup=always as the default for SavedSearch export, since the expectation is generally for packaged searches to be cleaned up along with their extensions.
|
(Standard links)
|
kurund
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This sets all AdminUI saved searches to be deleted during uninstall, for a cleaner uninstall process. It also sets cleanup=always as the default for SavedSearch export, since the expectation is generally for packaged searches to be cleaned up along with their extensions.
Before
SavedSearches not cleaned up when uninstalling the CiviCRM Admin UI extension.
After
SavedSearches cleaned up when uninstalling the CiviCRM Admin UI extension.