dev/core#3914 Add getRoleNames() method for WordPress

[bastienho]

Overview

Fixes the Missing getRoleNames() method in WordPress System Utility issue.

Some extensions use the CRM_Core_Config::singleton()->userSystem->getRoleNames() method, which is not implemented for WordPress

Before

On a WordPress install, CRM_Core_Config::singleton()->userSystem->getRoleNames() return NULL;

After

CRM_Core_Config::singleton()->userSystem->getRoleNames() returns

Array
(
    [administrator] => Administrator
    [editor] => Editor
    [author] => Author
    [contributor] => Contributor
    [subscriber] => Subscriber
    [anonymous_user] => Anonymous User
)

Technical Details

Uses wp_roles()

[civibot]

(Standard links)

• If this is your first pull-request for CiviCRM, please browse CONTRIBUTING.md for information about the development and testing processes.
• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[civicrm-builder]

Can one of the admins verify this patch?

[seamuslee001]

Jenkins add to white list

[seamuslee001]

this seems ok to me thoughts @kcristiano @haystack?

[seamuslee001]

Jenkins add to whitelist

[totten]

This seems intuitively sensible.

@bastienho I think the test bot is complaining because the blank line (1286 above) has some invisible space characters. If you can delete the space-characters, then it should accept it.

[kcristiano]

This looks sensible. I've applied the patch to my RC testimg site to test. @bastienho do you have an example of an extension that I can specifically test?

[bastienho]

Hi I'll clean-up the dummy spaces. I was trying to use this extension when I found the missing method : https://lab.civicrm.org/extensions/hierarchicalacl/-/blob/1.x/CRM/HierarchicalACL/Form/Config.php#L132 21 oct. 2022 13:15:28 Kevin Cristiano ***@***.***>:

…

This looks sensible. I've applied the patch to my RC testimg site to test. @bastienho[https://github.com/bastienho] do you have an example of an extension that I can specifically test? — Reply to this email directly, view it on GitHub[#24751 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AASMK6IHNNRJSZKUD3AJME3WEJ3MBANCNFSM6AAAAAARFIS3TE]. You are receiving this because you were mentioned.[Image de pistage][https://github.com/notifications/beacon/AASMK6OYXT4IHAOPYGD42ZTWEJ3MBA5CNFSM6AAAAAARFIS3TGWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTSMWNAOS.gif]

[kcristiano]

That's odd on CiviCRM master enabling that extension fails

Enabling extension "hierarchicalacl"
Error: API Call Failed: Array
(
    [entity] => Extension
    [action] => install
    [params] => Array
        (
            [keys] => Array
                (
                    [0] => hierarchicalacl
                )

            [debug] => 1
            [version] => 3
        )

    [result] => Array
        (
            [is_error] => 1
            [error_message] => Unknown extension: jsoneditor
            [xdebug] => Array
                (
                )

        )

)

Just standard buildkit extensions installed

key	name	status	version
authx	authx	installed	5.56.alpha1
civicrm_admin_ui	civicrm_admin_ui	uninstalled	5.56.alpha1
civigrant	civigrant	installed	5.56.alpha1
civiimport	civiimport	uninstalled	5.56.alpha1
ckeditor4	ckeditor4	installed	5.56.alpha1
contributioncancelactions	contributioncancelactions	uninstalled	5.56.alpha1
elavon	elavon	uninstalled	5.56.alpha1
eu.tttp.civisualize	civisualize	installed	6.1
eventcart	eventcart	installed	5.56.alpha1
ewaysingle	ewaysingle	uninstalled	5.56.alpha1
financialacls	financialacls	installed	5.56.alpha1
greenwich	greenwich	installed	5.56.alpha1
hierarchicalacl	hierarchicalacl	uninstalled	1.1.0
legacycustomsearches	legacycustomsearches	installed	5.56.alpha1
message_admin	message_admin	uninstalled	5.56.alpha1
oauth-client	oauth_client	uninstalled	5.56.alpha1
org.civicoop.civirules	civirules	installed	2.44-dev
org.civicrm.afform	afform	installed	5.56.alpha1
org.civicrm.afform-html	afform_html	uninstalled	5.56.alpha1
org.civicrm.afform-mock	afform_mock	uninstalled	5.56.alpha1
org.civicrm.afform_admin	afform_admin	installed	5.56.alpha1
org.civicrm.angularex	angularex	uninstalled	1
org.civicrm.angularprofiles	angularprofiles	installed	1.2.2
org.civicrm.contactlayout	contactlayout	installed	2.1.1
org.civicrm.demoqueue	demoqueue	uninstalled	1
org.civicrm.flexmailer	flexmailer	installed	5.56.alpha1
org.civicrm.module.cividiscount	cividiscount	installed	3.8.6
org.civicrm.search_kit	search_kit	installed	5.56.alpha1
org.civicrm.volunteer	volunteer	installed	2.4.3
org.example.scssmethodtest	scssmethodtest	uninstalled	1
payflowpro	payflowpro	uninstalled	5.56.alpha1
recaptcha	recaptcha	installed	5.56.alpha1
sequentialcreditnotes	sequentialcreditnotes	installed	5.56.alpha1
sequentialcreditnotes	sequentialcreditnotes	installed	5.56.alpha1

[christianwach]

Seems like a sensible addition to me. I expect it's worth checking that "ACL Group/Role" multi-select functions as expected in whatever form it is that CRM_Report_Form_Instance::buildForm() renders - and that the functionality it implements works too.

BTW @seamuslee001 I know it's confusing, but someone grabbed my usual handle here before I did. 🤷

[kcristiano]

I've been able to do a number of r-run and see no reason not to merge (once the white space is cleaned up).

[bastienho]

Sorry guys, the white space is cleaned-up

[seamuslee001]

thanks @bastienho can you please also create a PR to add yourself to the Contributor Key file https://github.com/civicrm/civicrm-core/blob/master/contributor-key.yml