Standardise names as camelcase for "SearchKit" and "FormBuilder" #24726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
colemanw
reviewed
Oct 12, 2022
| @@ -87,7 +87,7 @@ public function __construct() { | |||
| * Whether to return the plural version of the title. | |||
| */ | |||
| public static function getEntityTitle($plural = FALSE) { | |||
| return $plural ? E::ts('Form Builder Submissions') : E::ts('Form Builder Submission'); | |||
| return $plural ? E::ts('FormBuilder Submissions') : E::ts('FormBuilder Submission'); | |||
There was a problem hiding this comment.
@aydun this is actually an autogenerated file. Have to edit the xml for this file and then go to the afform core extension dir and run civix generate:entity-boilerplate
There was a problem hiding this comment.
Ah, I see the xml file was updated too. That's fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Standardise on camelcase for 'SearchKit' and 'FormBuilder'
Before
Some places show 'Search Kit' and 'Form Builder'
After
Fewer (hopefully none) instances of 'Search Kit' and 'Form Builder'
Technical Details
Comments
#ManchesterSprint