Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afform - Fix picking default value for date field #24696

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Oct 8, 2022

Overview

Fixes dev/core#3846

Before

Unable to set default value for date field

After

Fixed

@civibot civibot bot added the master label Oct 8, 2022
@civibot
Copy link

civibot bot commented Oct 8, 2022

(Standard links)

@jackgleeson
Copy link

  • General standards
    • Explain (r-explain)
      • PASS : The goal/problem/solution have been adequately explained in the PR.
    • User impact (r-user)
      • PASS: The change would be intuitive or unnoticeable for a majority of users who work with this feature.
    • Documentation (r-doc)
      • PASS: The changes do not require documentation.
    • Run it (r-run)
      • PASS: Pulled down fix, created default form with default Birthdate field and saved successfully. I then confirmed the default date was displayed when browsing the test form. All good!
  • Developer standards
    • Technical impact (r-tech)
      • PASS: The change preserves compatibility with existing callers/code/downstream.
    • Code quality (r-code)
      • PASS: The functionality, purpose, and style of the code seems clear+sensible.
    • Maintainability (r-maint)
      • PASS: The change does not sufficiently improve test coverage, but special circumstances make it important to accept the change anyway.
    • Test results (r-test)
      • PASS: The test results are all-clear.

@kurund
Copy link
Contributor

kurund commented Oct 10, 2022

thanks @jackgleeson

@colemanw colemanw merged commit 051323e into civicrm:master Oct 10, 2022
@colemanw colemanw deleted the fixDefaultDatepicker branch October 10, 2022 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants